search

sagiegurari / cargo-make

Rust task runner and build tool.
https://sagiegurari.github.io/cargo-make/
Apache License 2.0
2.46k stars 123 forks source link

fix: reset CARGO env var to fix wrong CARGO in commands #1060

Closed wmmc88 closed 3 months ago

wmmc88 commented 3 months ago

fixes #1059

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.83%. Comparing base (d3c7483) to head (04adb47).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1060 +/- ## ========================================== - Coverage 92.84% 92.83% -0.01% ========================================== Files 118 118 Lines 24236 24239 +3 ========================================== + Hits 22501 22502 +1 - Misses 1735 1737 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wmmc88 commented 3 months ago

codecov/project seems to be failing because it considers the toolchain_test.rs file as requiring tests

wmmc88 commented 3 months ago

@sagiegurari anything else needed from me to get this merged in?

sagiegurari commented 3 months ago

sorry fir the delay. I'll meege and publish a new version mid next week

wmmc88 commented 3 months ago

sorry fir the delay. I'll meege and publish a new version mid next week

@sagiegurari friendly bump 🙂

sagiegurari commented 3 months ago

@wmmc88 thanks a lot. looks good. i'm merging to dev branch, doing few checks, check other issues and than i'll release.