Closed 06393993 closed 2 months ago
It seems to me that all integration tests are ignored, so I didn't add any integration tests for this feature. Please let me know if I am missing anything. Thanks.
tests are split to multi and single threaded. they are not ignored but you cant teat cargo make with cargo test. only via cargo make itself
Added 2 integration tests. One thread safe, one not thread safe. Verified locally with:
cargo nextest run -E 'test(run_flow_skip_init_end_tasks)' --run-ignored all
andcargo nextest run -E 'test(print_skip_init_end_tasks)' --run-ignored all
.@06393993 looks good.
@06393993 can you fix the tests please? also moved it to a new dev branch
~I figured out the failure: for not thread-safe tests, we are setting the global logger in the new test, which may causes other tests to panic on error!
. The fix is to reset the global logger after the newly added test completes.~
EDIT: actually I incorrectly use "test2" instead of the correct "task2" in the failed execution_plan::execution_plan_test::create_task_extends_empty_env_bug_verification
test.
I have run cargo run --bin cargo-make --target-dir target/ci -- make ci-flow
locally on my machine to make sure it passes the currently failed github action step.
Attention: Patch coverage is 67.22689%
with 78 lines
in your changes missing coverage. Please review.
Project coverage is 69.27%. Comparing base (
e3e93de
) to head (4dfc585
).
:exclamation: There is a different number of reports uploaded between BASE (e3e93de) and HEAD (4dfc585). Click for more details.
HEAD has 3 uploads less than BASE
| Flag | BASE (e3e93de) | HEAD (4dfc585) | |------|------|------| ||4|1|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@06393993 merging. thanks a lot. i hope i'll release it this soon
Fix #1108.