sagiegurari / shell2batch

Coverts simple basic shell scripts to windows batch scripts.
Apache License 2.0
57 stars 7 forks source link

cp fails, folder treated as a flag #2

Closed roblabla closed 5 years ago

roblabla commented 5 years ago

Describe the bug cp seems to be coverted to xcopy, which doesn't support forward slashes to separate path items. As a result, running cp linker-scripts/bootstrap.ld link.T results in:

xcopy linker-scripts/bootstrap.ld link.T
Invalid switch - /bootstrap.ld

To Reproduce

Code Sample

/// paste code here
roblabla commented 5 years ago

This seems to be a pitfall in almost all the commands actually. move also accepts only \-delimited path items for instance. I'm thinking of adding an extra flag to convert_line's big match, "convert_paths", that, if true, will basically replace all / with \.

sagiegurari commented 5 years ago

thanks, will fix

sagiegurari commented 5 years ago

just released new 0.3.0 version with this fix for specific commands. i'll be releasing a new cargo-make version which will use this new shell2batch as well soon

sagiegurari commented 5 years ago

going to close this for now. if there are more issues just reopen or open a new issue.