search

sagiegurari / simple-oracledb

Extend capabilities of oracledb with simplified API for quicker development.
Apache License 2.0
36 stars 4 forks source link

TypeScript Definition Files #18

Closed wahmedswl closed 7 years ago

wahmedswl commented 7 years ago

Problem Description

Hi, it would be great to have TypeScript Definition Files as official oracle driver have that and it helps in rich experience in VSCode.

Thanks

cjbj commented 7 years ago

Duplicate of #169 - this links to the TypeScript definitions.. When 1.12 is released to npm, I was going to nude @bigous to see if he can update them

cjbj commented 7 years ago

Crap - wrong repo! Sorry @sagiegurari

sagiegurari commented 7 years ago

In this repo, I don't think this will happen. Too much maintenance because I got a lot of apis and I don't want to manage that. You might want to look like @cjbj stated at oracle/node-oracledb#169 and see there, which basically an external contributor created that definition and submitted it to https://github.com/DefinitelyTyped/DefinitelyTyped So you can do the same and I can reference your definitions file in my docs.