sagikazarmark / helm-charts

Various Helm charts for my own and other projects
MIT License
43 stars 56 forks source link

Support for restart policy in sftpgo Helm Chart #147

Open agmimidi opened 2 years ago

agmimidi commented 2 years ago

Hi,

We are seeing an issue where when we upgrade our chart the new pod gets stuck in Container Creating state.

This happens because the old pod is still there and holds access to the persistent volume claim. The only way around this at the moment is to force delete the old pod. Adding support for pod restart policy or allowing deploying as a state-full set should solve the issue.

Cheers and thanks for the chart :) Angelos

sagikazarmark commented 2 years ago

@agmimidi which chart are you talking about?

agmimidi commented 2 years ago

https://github.com/sagikazarmark/helm-charts/tree/master/charts/sftpgo

Tis on the issue title 😁

agmimidi commented 2 years ago

@sagikazarmark Did you have a chance to look into this?

Cheers, Angelos

sagikazarmark commented 2 years ago

Sorry, I have not.

I'm a bit confused though: Isn't deployment strategy that you want to change: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy