sagikazarmark / helm-charts

Various Helm charts for my own and other projects
MIT License
43 stars 55 forks source link

Add options to SFTPGO deploy. #196

Open mdeterman opened 1 year ago

mdeterman commented 1 year ago
sagikazarmark commented 1 year ago

Thanks for the contribution!

Can you tell me what your use case for changing the command and args is? Is it something considered a good practice in the community today?

Thanks!

mdeterman commented 1 year ago

This is common in most charts. I do use this functionality with MutatingWebhookConfiguration. I have cases where I will override the command and args to inject extra command/shell scripts on deployment (mostly for secret injection).

Let know if you have any more question.

Thanks,

On Nov 14, 2023, at 8:47 PM, Márk Sági-Kazár @.***> wrote:

Thanks for the contribution!

Can you tell me what your use case for changing the command and args is? Is it something considered a good practice in the community today?

Thanks!

gioppoluca commented 11 months ago

+1 to this

mdeterman commented 9 months ago

@sagikazarmark Can i get a review of this and see if we can get this merged

cnellis101 commented 5 months ago

+1 to this as well, adding sidecar containers would be a huge help.

Ant0wan commented 3 months ago

+1