search

sagnik1511 / Tabular-AutoML

Python Auto-ML Package for Tabular Datasets
MIT License
23 stars 13 forks source link

Adding KNN classifier #22

Closed VishnuBhaarath closed 2 years ago

VishnuBhaarath commented 2 years ago

The PR fix for issues #7

Added KNN classifier to models.py the advantage of this is it takes almost zero time to train because it only stores the data of the training part. and faster than all the models mentioned in the models.py file , it is also a non parametric models with only parameter that needs to be mentioned is the number of neighbours, adding to this as KNN doesnt undergo training we can add new data to it which doesn't affect the accuracy of the model. It is also very easy to implement and interpret as there is only one hyperparameter which is the number of neighbours .

sagnik1511 commented 2 years ago

@VishnuBhaarath, Please update a single at any instance on a single repo.

VishnuBhaarath commented 2 years ago

@VishnuBhaarath, Please update a single at any instance on a single repo.

have added space as well as made c capital can you please elaborate on this comment, thanks

sagnik1511 commented 2 years ago

@VishnuBhaarath , Please change the branch name as stated in README.md

VishnuBhaarath commented 2 years ago

@VishnuBhaarath , Please change the branch name as stated in README.md

yeah sure will do it.

VishnuBhaarath commented 2 years ago

@VishnuBhaarath , Please change the branch name as stated in README.md

yeah sure will do it.

Have made a new pull request with my github username as a branch, kindly check it and can this PR be closed?