search

sagold / handlebars-webpack-plugin

Renders your html-template at build time
161 stars 45 forks source link

WDS support #15

Closed baldurh closed 7 years ago

baldurh commented 7 years ago

I was trying to use this plugin with Webpack Dev Server and found out that the partials are only once read from disk — when the plugin instance is created. So when we changed the partials the compiled file did not change. I made it work for us by registering the partials on every compile.

This may need some refining before being accepted into this project, e.g. should onBeforeAddPartials be called every time, etc. So I just decided to create this PR and have the discussion here.

sagold commented 7 years ago

Hi baldurh.

Thanks for your contribution. I merged your commit ca935be56ca9ae7a8f0ffe5f5177948082d67050 and made some additions. With version v1.1.0 partial changes are registered and wds is notified.

Cheers. sagold