sagold / handlebars-webpack-plugin

Renders your html-template at build time
161 stars 45 forks source link

Usage with html-webpack-plugin broken #68

Closed rustyy closed 4 years ago

rustyy commented 4 years ago

As of version 4.0.0 of html-webpack-plugin the plugin can't be used in combination with handlebars-webpack-plugin anymore.

In version 4.0.0 the "AfterHtmlProcessing"-hook has been renamed to "beforeEmit".

This leads to a type error:

node_modules/handlebars-webpack-plugin/index.js:128 compilation.hooks.htmlWebpackPluginAfterHtmlProcessing.tap("HandlebarsRenderPlugin", data => ...
TypeError: Cannot read property 'tap' of undefined

https://github.com/sagold/handlebars-webpack-plugin/blob/b8c7af5106c8f5d3b49428c4cd450ea11e4f8e67/index.js#L124

Environment

Dependencies:

"handlebars": "^4.7.6",
"handlebars-webpack-plugin": "^1.8.1",
"html-webpack-plugin": "^4.3.0",
"webpack": "^4.43.0",
"webpack-cli": "^3.3.11",

Resources

rustyy commented 4 years ago

Uups duplicate to #66 , sorry