sagold / handlebars-webpack-plugin

Renders your html-template at build time
161 stars 45 forks source link

Correct typ-oh in getPartialId function documentation #69

Closed queenvictoria closed 3 years ago

queenvictoria commented 4 years ago

Fixing getPartialId function documentation so it works out of the box. I've kept the filePath variable as you've required the path library throughout the documentation and this means that the function reads more clearly.

It should possibly use the regex from utils/partials.js but I'll leave that to your discretion.

/* from README.md */
(/\/([^/]+\/[^/]+)\.[^.]+$/)
/* from utils/partials.js */
(/\/([^\/]+\/[^\/]+)\.[^\.]+$/)
sagold commented 3 years ago

Nice catch. Thank you!