Feature/#78 - Githubissues

sagold / handlebars-webpack-plugin

Renders your html-template at build time

162 stars 45 forks source link

Feature/#78 #81

Closed sw1tchdev closed 3 years ago

sw1tchdev commented 3 years ago

Ref: #78 Tested with:

[x] Webpack 5.11.0, Html-webpack-plugin 5.0.0-beta.1
[x] Webpack 4.44.2, Html-webpack-plugin 4.5.0

Hello, this PR fixed a DeprecationWarning with using Webpack v5. Please check this PR. Also need think about package.json, need update peerDependencies for html-webpack-plugin(if you use npm v7 you can install only with --legacy-peer-deps flag).

sagold commented 3 years ago

Hi sw1tchdev,

thank you very much. The PR looks great. I will test and release it.

Cheers, sagold

sagold commented 3 years ago

There seems to be a problem in the order of the hooks, when using in conjuction with Html-webpack-plugin.

To my current understanding PROCESS_ASSETS_STAGE_SUMMARIZE should emit after HtmlWebpackPlugin.getHooks(compilation).beforeEmit, where the html-partials are registered to hbs. Maybe this is caused by changes in the latest Html-webpack-plugin.

sagold commented 3 years ago

I will merge this PR and continue testing on develop. Any new release will be announced in issue#78.

Thanks again, for your help!