sagreine / homeGym

homeGym mobile app
2 stars 0 forks source link

edit button on full day #174

Closed sagreine closed 3 years ago

sagreine commented 3 years ago

just do it briefly for now

sagreine commented 3 years ago

issues/items 1) thisSetPRSet but that doesnt help us because we (have to) set against the controller value on do_lift view, not this flag. i think we came to this solution because otherwise it was adding xPR every time the page built, including when we edit the reps on that page. or, perhaps it was moving the cursor to the front with that. in any case, will need to refine that in concert with this and make sure whatever we do is correct there too. could do via focus + submit like we did here too... 2) rest period doesn't seem to update 3) need to make the calculated weights recalculate. at least for main lifts? that is, use the model's functions don't just update things directly for christ'ssake. recalc if the use barbell is selected.

4) but this is going to get weird for like front squats, so might ask them to tell us which bar they're using for this set if any and then calculate the weight that way. 
`      a) show the 1rm and (reps)RM of the relevant lift`
      b) add a bool for usesBarbell to exercise

5) was going to have a red x and green check mark for editing, but having a copy of how it looked on the way in and 'undoing' seems like a lot of hassle for not much benefit? maybe for future consideration... -> use FAB 6) added a copy icon. we'll see if that makes it in though. 7) done editing button needs to stick to the bottom not scroll 8) if weight is < barbell weight, set it equal to barbell weight and tell them about it. - sketch but done

9. prescribed reps is final. should it not be, then. this also has implications for how we insert a new exercise
10. just use provider and avoid all of this nonsense
11. allow them to set the weight as a pct of 1 rep max? then select which lift that is? that brings us closer to the build-new-program mode... -> this is still an issue. might be intertwined with number 1 tho!
12. show what % of 1RM this is, or what % of TM this is, or what % of X RM this is on the edit page (and elsewhere?)
13. some sets without soft wrap = too wide, on the full day view page -> might just be a "live with it" moment. or try expanded i guess, but i think i prefer all sets being the same height anyway...
sagreine commented 3 years ago

-ask them if this is a "Main lift of the day" program, then ask them if this set is a "main" lift - if so, blank out the title and set it to "Main". they can then add as many different "main" day options to the main page and pick from there. still only have the 4 main lifts on the Maxes page and "% of max for X lift" list. -ask them which week it is and **bring that week to the edit set page** somehow? so they don't have to make 3 separate weeks from scratch from each program. maybe if they said there were weeks and they say it is percentage, have 3 percentage boxes? but how will we tie across weeks... for consideration:

if we let them pick a 1rm lift to base it off of, how do we store that in the db through application?
that is, right now in the app we (lazily) process based off a title o "Main" and use that, based on 5/3/1 date and as the indicator to use the percentage.
but, in this case, we are letting them set the title. so we don't want to, say, override that to "Main" in cases that this is not a Main lift. If it is though, we can do that (see second point above). 

`so, use case in question is like:

I want front squat. it is not a "Main lift" program. I want it to be 65%, 75%, 85% of squat 1RM for weeks 1, 2, 3. 
in application on creation:
maybe we let them say how many weeks there are, then tell them to complete week 1 before building week 2, complete that before building week 3?
in firestore:
could store the lifts in an array just like now
could store an array of booleans for "based on percentage" 
could store an array of "lift that it is a % of"
in application on usage of the program:
more or less just how it is done now. in addition to checking "Main" we check those two other arrays. 

One thing is that we will be pulling "Your Programs" from a different schema so we can be flexible here if need be. 
sagreine commented 3 years ago
two types of progressions we support
-linear, e.g. 5/3/1, and we calculate it for you
-DIY

5/3/1 support is in.

To support APRE:
not sure?
could tell them to override the training max pct and adjust 1RM at the end of the cycle?

To support RPE:
Need to help them by adding 
RPE to exercise everywhere.
Can show them RPE on the main form in a field they can enter, previous RPE weights & reps, etc. 
tell them to update their 1RM after the fact? auto-update it if the weight is > than that number?
sagreine commented 3 years ago

the rest of this is on #11