Use headless Chrome instead of PhantomJS to run tests 🤖

saguijs / sagui

:monkey: Front-end tooling in a single dependency

http://sagui.js.org/

MIT License

669 stars 32 forks source link

Use headless Chrome instead of PhantomJS to run tests 🤖 #337

Closed pirelenito closed 6 years ago

pirelenito commented 7 years ago

We have a couple of options going forward:

Always ship with the default PhantomJS support but use Chrome if it is available;
Completely ditch PhantomJS, and make Chrome another global dependency of Sagui.

However, it is currently only available in the Canary release.

More info https://www.chromestatus.com/features/5678767817097216

pirelenito commented 7 years ago

We should also use the official support https://github.com/karma-runner/karma-chrome-launcher/pull/111 once it is merged.

xaviervia commented 7 years ago

How does this relate to the PR for switching to Electron? Should we reject that one? Seems like barebones Chromium is the way to go, clearly closer to metal than Electron.

pirelenito commented 7 years ago

I think it is time for us to push this! https://developers.google.com/web/updates/2017/06/headless-karma-mocha-chai

Headless support is already in Chrome stable!

pirelenito commented 6 years ago

@npejo is preparing a new PR with a final solution. Rejecting this for now.