search

saguijs / sagui

:monkey: Front-end tooling in a single dependency
http://sagui.js.org/
MIT License
669 stars 32 forks source link

yarn test:lint passes anyways in 9.0.0-rc.16 #358

Closed abdulhannanali closed 7 years ago

abdulhannanali commented 7 years ago

Summary

I want to report a bug I found in v9.0.0-rc.16 while checking out react-context-props which just adopted it.

yarn test:lint exits with code 0 and shows as though there are no lint errors within the repository, although there are.

Reproduction of issue

Created a minimal bug reproduction repo, specifically check src/index.js which contains errors, according to the rules specified in sagui, but yarn test:lint still passes with exit code 0

Link: https://github.com/abdulhannanali/sagui-bug-eslint

pirelenito commented 7 years ago

Thank you so much for reporting it. I have a PR with a fix WIP.

pirelenito commented 7 years ago

I've released the fix as part of https://github.com/saguijs/sagui/releases/tag/v9.0.0-rc.17

But we should also try to get #361 done soon.