search

saguijs / sagui

:monkey: Front-end tooling in a single dependency
http://sagui.js.org/
MIT License
669 stars 32 forks source link

Update to Wepback 3 #373

Closed pirelenito closed 7 years ago

pirelenito commented 7 years ago

The biggest improvement it brings is scope hoisting:

Because scope hoisting will remove function wrappers around your modules, you may see some small size improvements. However, the significant improvement will be how fast the JavaScript loads in the browser.

For more information check: https://medium.com/webpack/webpack-3-official-release-15fd2dd8f07b

And although it is a major release of Webpack, it isn't exactly an API breaking change, so upgrading should be fairly smooth. I guess the v9 release will be outpaced pretty quickly.

pirelenito commented 7 years ago

@npejo you have a pretty big project with Sagui, could you try it out and post what improvements it brings in comparison with v9? ❤️

pirelenito commented 7 years ago

It looks like we might encounter an issue: https://mobile.twitter.com/i/web/status/877378116028514304

pirelenito commented 7 years ago

https://github.com/webpack-contrib/extract-text-webpack-plugin/issues/548

npejo commented 7 years ago

Thanks for preparing this branch @pirelenito, I will check it on our project.

xaviervia commented 7 years ago

I’m labeling this as in progress until we investigate that issue more

pirelenito commented 7 years ago

We're just waiting for the 3.0.0 release of extract-text-webpack-plugin, that should be out by tomorrow.