saguijs / sagui

:monkey: Front-end tooling in a single dependency
http://sagui.js.org/
MIT License
669 stars 32 forks source link

Mimic how Node scans for modules © #376

Closed pirelenito closed 7 years ago

pirelenito commented 7 years ago

More information: https://webpack.js.org/configuration/resolve/#resolve-modules

This will require a major version bump.

pirelenito commented 7 years ago

@moriaam, as we discussed, this should fix the problem you are having.

pirelenito commented 7 years ago

@xaviervia I just updated the tests so that they are more descriptive.

I also noticed that I didn't commit all the required files (because they were being git ignored).

pirelenito commented 7 years ago

Also, do you all agree this should be a major version? It could be considered a bug as well... I'm not 100% sure to be honest.

pirelenito commented 7 years ago

@npejo, @Deschtex, I would love your input on this. Do you think this would be a change for a major version bump?

pirelenito commented 7 years ago

@moriaam, you are not a contributor to Sagui, but I would also like to hear your thoughts. Do you think this is a breaking change?

pirelenito commented 7 years ago

It could as well be considered a bug...

moriaam commented 7 years ago

I wanna say bugfix but it can mess up other projects so go safe with a major version.

pirelenito commented 7 years ago

Interestingly, I wonder if we should also do the same as https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/config/webpack.config.dev.js#L89

pirelenito commented 7 years ago

This is ready for the final review! Lets keep the same behavior as Node.js!

pirelenito commented 7 years ago

Me and @npejo also tested this change in a big project and it worked fine. I'm merging and doing a major release.