Closed pirelenito closed 7 years ago
@moriaam, as we discussed, this should fix the problem you are having.
@xaviervia I just updated the tests so that they are more descriptive.
I also noticed that I didn't commit all the required files (because they were being git ignored).
Also, do you all agree this should be a major version? It could be considered a bug as well... I'm not 100% sure to be honest.
@npejo, @Deschtex, I would love your input on this. Do you think this would be a change for a major version bump?
@moriaam, you are not a contributor to Sagui, but I would also like to hear your thoughts. Do you think this is a breaking change?
It could as well be considered a bug...
I wanna say bugfix but it can mess up other projects so go safe with a major version.
Interestingly, I wonder if we should also do the same as https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/config/webpack.config.dev.js#L89
This is ready for the final review! Lets keep the same behavior as Node.js!
Me and @npejo also tested this change in a big project and it worked fine. I'm merging and doing a major release.
More information: https://webpack.js.org/configuration/resolve/#resolve-modules
This will require a major version bump.