search

saguijs / sagui

:monkey: Front-end tooling in a single dependency
http://sagui.js.org/
MIT License
669 stars 32 forks source link

Add missing ESLint dependencies and drop PhantomJS integration testing #407

Closed xaviervia closed 6 years ago

xaviervia commented 6 years ago

Yarn and NPM are no longer flatting these dependencies, and we need to make them explicit of Sagui.

Also drops testing of PhantomJS since we are about to phase it out.

pirelenito commented 6 years ago

Awesome! Thanks @xaviervia

The build in Travis is failing because of an issue with Chrome Bin and PhantomJS 😭

We should try to find a fix for that in a separated PR first. I can help you out.

pirelenito commented 6 years ago

This will fix #405

pirelenito commented 6 years ago

We need to merge https://github.com/saguijs/sagui/pull/408 and update this branch.

pirelenito commented 6 years ago

I've update this branch so that we get it green.