search

sahana / WACOP

Washington State Common Operating Picture
0 stars 0 forks source link

Show / Hide timeline on map filter #23

Open dhornbein opened 7 years ago

dhornbein commented 7 years ago

@flavour How can we show/hide the timeline filter elements?

The ideal outcome would be a button that would show/hide the date-filter-chart, range-picker, and the start/end time fields.

Can we wrap these in a block with a class name? Otherwise I think we could target them with jQuery and put them into a block. What are your thoughts?

flavour commented 7 years ago

It should be easy for me to wrap in a DIV...will you then add the button? or at least the design?

flavour commented 7 years ago

Wrapper done...was indeed super-easy: https://github.com/sahana/eden/commit/75be9789635a6834363abb5691778589f7b9d47a

dhornbein commented 7 years ago

Should I add the button to modules/s3/s3filter.py or via jQuery? What's the best practice?

flavour commented 7 years ago

This widget is doing it all in s3.filter.js currently

dhornbein commented 7 years ago

I completed it via jQuery. It's a bit hacky, if you have a better way to trigger this please do.

There seems to be some issues with drawing the timeline, do you have a solution for redrawing the timeline on toggle?

screen shot 2017-09-27 at 2 49 08 pm

I appears to draw the timeline while it's shrinking...

dhornbein commented 6 years ago

@flavour should I make a PR with this working but buggy implementation? I think we just need to redraw the timeline after revealing the timeline.

flavour commented 6 years ago

Sure, make a PR, then it can be reviewed there...perhaps I'll take elements from it & place it into a full solution