search

sahana / eden

Sahana Eden is an Open Source Humanitarian Platform which can be used to provide solutions for Disaster Management, Development, and Environmental Management sectors.. Please sign CLA when submitting pull requests: http://bit.ly/SSF-eCLA
http://eden.sahanafoundation.org
Other
387 stars 559 forks source link

A branch will never be taken. #1590

Closed openrefactory closed 1 year ago

openrefactory commented 1 year ago

In file: parser.py, the comparison of Collection length creates a logical short circuit. The path in the code will never be taken. I am not suggesting a fix, just raising attention to the inconsistency here.

flavour commented 1 year ago

This code is in a 3rd-party vendored submodule, so I am reluctant to patch it unless absolutely necessary. We can update our submodule if there is a better upstream version, or if it still needs fixing upstream then that is best done there.