sahat / hackathon-starter

A boilerplate for Node.js web applications
MIT License
34.8k stars 8.16k forks source link

add joi for req validation #1198

Closed erfuuan closed 1 year ago

erfuuan commented 1 year ago

Hello everyone I am a Junior Nodejs developer and i found this project in github I can add Joi for request validation data . is it good? can someone help me about contribute?

s1ckn3zz1337 commented 1 year ago

I would rather use AVJ as it‘s faster than joi…

https://ajv.js.orghttps://ajv.js.org/

Am 16.09.2022 um 21:35 schrieb erfan @.***>:



Hello everyone I am a Junior Nodejs developer and i found this project in github I can add Joi for request validation data . is it good? can someone help me about contribute?

— Reply to this email directly, view it on GitHubhttps://github.com/sahat/hackathon-starter/issues/1198, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABVYF2LVSWJRVNLE6ZWAJDDV6TDZLANCNFSM6AAAAAAQOTMOII. You are receiving this because you are subscribed to this thread.Message ID: @.***>

erfuuan commented 1 year ago

It's true, now that I looked at npm, I noticed that it has a higher number of installs Does the person in charge of this project agree with adding AJV?

erfuuan commented 1 year ago

@sahat can you help me :)) I have some good ideas for tidying up the code

mehulbaid commented 1 year ago

@erfuuan I have done this before with joi. add me too.

YasharF commented 1 year ago

Can you elaborate more on the use case?

YasharF commented 1 year ago

Closing this issue due to lack of use cases.

erfuuan commented 10 months ago

Closing this issue due to lack of use cases.

Hello, is it possible to reopen this issue? I can assist you in improving the code.