search

sahat / hackathon-starter

A boilerplate for Node.js web applications
MIT License
34.8k stars 8.16k forks source link

Secure Env Not Used for ENV Keys #1210

Closed mehulbaid closed 1 year ago

mehulbaid commented 1 year ago

In ref to #1127 , Sendgrid keys are exposed publically.

I can fix this.

mehulbaid commented 1 year ago

@sahat - Please prioritise this.

renovX commented 1 year ago

can i solve this issue? Thank you

mehulbaid commented 1 year ago

I already am on it

YasharF commented 1 year ago

Can you elaborate more on what you mean by "Sendgrid keys are exposed publically" ?

YasharF commented 1 year ago

Going to close this issue due to no response. The original issue "Sendgrid keys are exposed publically" is invalid.

YasharF commented 1 year ago

Added security.md reiterating that the values in the .env file are placeholders for anyone that missed to go thru the README.MD and hasn't used the project: https://github.com/sahat/hackathon-starter/commit/80af16175880763cfdd0a0ebc44298842a7b0fbf