search

sahat / hackathon-starter

A boilerplate for Node.js web applications
MIT License
34.84k stars 8.16k forks source link

Fixed Issue #1273 : Cookies gets destroyed on signout #1276

Closed AryanMankame closed 12 months ago

AryanMankame commented 1 year ago

Hey! I just added the code to delete the cookies on Signout the based on the class of Signout button which is image in header.pug the code to delete the cookies image is added!

YasharF commented 12 months ago

As a security practice, cookie management is done from the server side because there is no guarantee that the client will follow thru and delete the cookie.

AryanMankame commented 12 months ago

Hi YasharF I'm new to open source, based on the description of the issue I thought when user logs out the cookies stored on the client browser needs to be deleted so I wrote code for. As marking it as a spam raises a flag for me in hacktoberfest so please can you kindly remove the spam tag

YasharF commented 12 months ago

Hacktoberfest is a great event to get dev involved in open source. However, it also causes a lot of people to just submit PRs to repos in hope of getting credit for hacktoberfest. These PRs are mostly spam because they are not needed. Spam by definition is any kind of unwanted or unsolicited digital communication or submission.

Before creating PRs in the future, I would suggest deep diving into the code to understand the current implementation, review the current github issues that have been vetted by the maintainers, and or if you have identified a potential issue ask questions about it to validate and verify if it is something that needs to be fixed.