Closed VatsalBhuva11 closed 8 months ago
Can you fix the issue with File Upload as well?
Sure, I'll do it. I'm very sorry, I must've overlooked it in your original request. I changed Google Maps instead of File Upload. I'll make the necessary changes.
Should I make a new PR, or modify the commit in this PR to add these changes to ensure a single commit?
@YasharF I have made the requested changes in this single commit itself. The text-colours of the buttons that required changes are now either set to #000 or #fff, are uniform, and have a sufficiently high contrast ratio. I also changed the background-colour of the Google Maps button to the one used in the branding doc (#0f9d58). If any more changes are required, do suggest them.
Thank you
Fixes #1270
Brief Description:
Some of the buttons did not have a sufficient contrast ratio as per the W3C Web Content Accessibility Guidelines (WCAG). This PR solves that by changing the text/background colours of some of these buttons (Stripe, Foursquare, Google Maps, HERE Maps) buttons under the
/api/examples
endpoint to ensure that these buttons have a contrast ratio >= 7.Changes:
1) Stripe:
Screenshots:
References used: