sahat / hackathon-starter

A boilerplate for Node.js web applications
MIT License
34.77k stars 8.14k forks source link

Update README.md with new twitter logo #1287

Closed aslezar closed 8 months ago

aslezar commented 8 months ago

Updated Read Me with the new updated logo of twitter.

YasharF commented 8 months ago

Also, while you are at it, can you also go thru the readme.md and replace the word "Twitter" with "X (Twitter)" everywhere in that file?

aslezar commented 8 months ago

Also, while you are at it, can you also go thru the readme.md and replace the word "Twitter" with "X (Twitter)" everywhere in that file?

Yeah, sure! I have made the required changes.

YasharF commented 8 months ago

Let's set it as upper case (Twitter) instead of (twitter). I made a couple of comments in-line as well.

aslezar commented 8 months ago

Let's set it as upper case (Twitter) instead of (twitter). I made a couple of comments in-line as well.

Replaced twitter with Twitter.

I couldn't find any in-line comments that mention the word 'twitter'. If you're referring to the API routes or links like this one https://apps.twitter.com, I haven't changed them as it would affect functionality."

YasharF commented 8 months ago

Look at the PR in github, I commented the PR

aslezar commented 8 months ago

Hey, thanks for your time, but I didn't quite understand what you're talking about. It would be great if you could elaborate a bit, if possible. 😅

YasharF commented 8 months ago

@aslezar

image
aslezar commented 8 months ago

@aslezar image

Thanks for the help! I have made the requested changes.

YasharF commented 8 months ago

The logo completely disappears in dark mode

image
aslezar commented 8 months ago

I have updated it with the jpg image, it will render now correctly in dark mode.

YasharF commented 8 months ago

Thank you!