search

sahat / hackathon-starter

A boilerplate for Node.js web applications
MIT License
34.88k stars 8.18k forks source link

Fix Linkedin integration and example #979

Closed YasharF closed 5 years ago

YasharF commented 5 years ago

LinkedIn recently deprecated their API v1 in favor of v2. node-linkedin npm module has not been updated by its author in about two years and seems to be abandoned. passport-linkedin-oauth2 now supports the v2. The scope of this issue is to migrate off of node-linkedin while keeping passport-linkedin-oauth2 for obtaining tokens. passportjs configs may need some adjustments due to the new API, while the controller for the linkedin API example would need to be rewritten.

API v2 capabilities: https://www.linkedin.com/developers/products

YasharF commented 5 years ago

https://docs.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/migration-faq

YasharF commented 5 years ago

It looks like besides sign-in by LinkedIn which provides the user's name and email address, the only other non-enterprise function that is remaining is sharing posts to LinkedIn on behalf of the user. Considering the current restrictions, it might be reasonable to remove the LinkedIn API example.

YasharF commented 5 years ago

https://github.com/sahat/hackathon-starter/commit/62ca9d7537b6b02d2b7ca619fed623f8fc276307