search

sahib / glyr

Glyr is a music related metadata searchengine, both with commandline interface and C API
GNU Lesser General Public License v3.0
248 stars 24 forks source link

Just some typo fixes #16

Closed ckorn closed 12 years ago

ckorn commented 12 years ago

Hello,

there were some typos found by lintian (Debian tool for checking source and binary packages) which I have fixed. Btw, I tried compiling the package on my server but it failed with this message. There is definitely a 64bit CPU running on the server: cd "/build/build-libglyr_0.0.0+git20120214-1~getdeb1-amd64-qUOMNq/libglyr-0.0.0+git20120214/obj-x86_64-linux-gnu/lib" && /usr/bin/gcc -Dglyr_EXPORTS -Wall -Wextra -Wstrict-prototypes -std=c99 -W -Wno-unused-parameter -Wno-strict-prototypes -g -O2 -Wall -Wextra -Wstrict-prototypes -std=c99 -W -Wno-unused-parameter -Wno-strict-prototypes -g -O2 -Os -march=native -s -fPIC -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -o CMakeFiles/glyr.dir/glyr.c.o -c "/build/build-libglyr_0.0.0+git20120214-1~getdeb1-amd64-qUOMNq/libglyr-0.0.0+git20120214/lib/glyr.c" /build/build-libglyr_0.0.0+git20120214-1~getdeb1-amd64-qUOMNq/libglyr-0.0.0+git20120214/lib/glyr.c:1:0: error: CPU you selected does not support x86-64 instruction set

I work for the Ubuntu software repository www.getdeb.net and want to publish the media player Pragha with builtin support of this library.

Best regards Christoph

ckorn commented 12 years ago

Sorry, this second commit (fb8390f) should not be in the pull request. But I do not know how to remove it. Just ignore it.

ckorn commented 12 years ago

Ahh, I just don't know how to use pull requests :/ Sorry, the last two commits never should show up here.

sahib commented 12 years ago

Hi, thanks for those fixes. /me writes 'separated' 10x

Honestly enough I never used the pull requests myself, so I'll just patch it the 'old' way. :)

Edit: at the compilation error: Could you try with CMAKE_BUILD_TYPE= "release" or "debug"? So I know if something is wrong with the flags. (A strange error you have there.)

ckorn commented 12 years ago

The compilation succeeds with CMAKE_BUILD_TYPE="debug". You can find the entire build log here: http://build.getdeb.net/build/logs/libglyr_0.0.0+git20120214-1~getdeb1-amd64-20120216-1311

The build log were it failed is here: http://build.getdeb.net/build/logs/libglyr_0.0.0+git20120214-1~getdeb1-amd64-20120216-1111

sahib commented 12 years ago

Thanks, this helped.

I removed -march=native (which was enabled only on for release), which seems to act very strange on different gcc versions. (gcc (GCC) 4.6.2 20120120 here) Can you confirm if it works?

ckorn commented 12 years ago

Yes, removing this flag works. Thank you.