search

sahib / rmlint

Extremely fast tool to remove duplicates and other lint from your filesystem
http://rmlint.rtfd.org
GNU General Public License v3.0
1.91k stars 132 forks source link

rmlint does 800 getwinsize syscalls per second with -g #425

Closed phiresky closed 4 years ago

phiresky commented 4 years ago

Feel free to close this if you think it's irrelevant, just noticed this while doing

sudo strace -e '!futex' -y -f -p $(pidof rmlint)

I saw that rmlint is doing 800+ syscalls like this

ioctl(1</dev/pts/13>, TIOCGWINSZ .. per second

Guessing it's to display the progressbar - I'm not sure if it impacts perf. just thought you should know.

sahib commented 4 years ago

Thanks for the hint. It didn't seem to have any noticeable performance effect, but I still fixed it as of 08574bdf020c25465cfa2b03d7593226099cb203.