sahib / rmlint

Extremely fast tool to remove duplicates and other lint from your filesystem
http://rmlint.rtfd.org
GNU General Public License v3.0
1.87k stars 130 forks source link

"1140 duplicates" is "0 B of duplicates which could be removed." #430

Closed bitsmack closed 3 years ago

bitsmack commented 3 years ago

Recently the post-scan report is showing "0 B of duplicates" even though valid duplicates are found. Please see the attached screenshot. The change happened recently, although I cannot associate it with any specific system update. I'm running an up-to-date version of Kubuntu 20.04.1.

rmlint_zerobytes

The output files, including rmlint.sh, are built correctly. I can execute the script and get rid of the dupes. The discovered duplicates are, in fact, duplicates. They exist in multiple places and are identical (as reported by diff). They are not zero-byte files :)

$ rmlint --version
version 2.9.0 compiled: Dec 31 2019 at [22:27:25] "Odd Olm" (rev 2)
compiled with: +mounts +nonstripped +fiemap +sha512 +bigfiles +intl +replay +xattr +btrfs-support

I am not experienced in this level of software dev, although I am strong with C for embedded devices. If this is a bug, please let me know what, if any, additional information I can provide to assist.

If this is a simple user error, please accept my apologies for wasting your time.

bitsmack commented 3 years ago

Hmm. I just did a different run, and the reporting was good.

The earlier case(s) have already been processed so I can't recreate them.

I will be using rmlint a lot over the next few days. If I see the problem again I will do some troubleshooting and see what might lead to the bad reporting. If I don't see the issue again, I'll come back and close (or delete) this ticket.

sahib commented 3 years ago

Hello @bitsmack, thanks for the report.

The output files, including rmlint.sh, are built correctly. I can execute the script and get rid of the dupes. The discovered duplicates are, in fact, duplicates. They exist in multiple places and are identical (as reported by diff). They are not zero-byte files :)

It sounds unlikely for that number of files, but were they all hardlinks of each other? I don't have any other idea right now and don't recall a bug like that.

version 2.9.0 compiled: Dec 31 2019 at [22:27:25] "Odd Olm" (rev 2)

That's an old version, so please check if it happens with a recent version (2.10.1):

https://rmlint.readthedocs.io/en/latest/install.html

bitsmack commented 3 years ago

Hmm. I just did a different run, and the reporting was good.

The earlier case(s) have already been processed so I can't recreate them.

I will be using rmlint a lot over the next few days. If I see the problem again I will do some troubleshooting and see what might lead to the bad reporting. If I don't see the issue again, I'll come back and close (or delete) this ticket.

Thanks, @sahib, for your response :)

bitsmack commented 3 years ago

Well, I can't replicate the issue. My apologies for using up a valuable issue number :)

Thank you for all of your work. This software has saved me countless hours. Take care!