Paranoid mode does not do anything if files are equal?

[james-cook]

I may be reading this wrong but: in "lib/formats/sh.sh":

    # Do double-check if requested:
    if [ -z "$DO_PARANOID_CHECK" ]; then
        return 0
    else
        if [ "$(check_for_equality "$1" "$2")" -ne "0" ]; then
            echo "${COL_RED}^^^^^^ Error: files no longer identical - cancelling.....${COL_RESET}"
            return 1
        fi
    fi
}

Should the code not explicitly "return 0" if the check_for_equality succeeds?

[james-cook]

On testing after just reading the generated script, it seems to work :) Should the code contain more explicit clear returns - or is it OK to leave it like this "fallthru style"?

[james-cook]

Well, it does work! so closing