Tests: replace nose with pytest

sahib / rmlint

Extremely fast tool to remove duplicates and other lint from your filesystem

http://rmlint.rtfd.org

GNU General Public License v3.0

1.86k stars 128 forks source link

Tests: replace nose with pytest #603

Open sbraz opened 1 year ago

sbraz commented 1 year ago

Hi, nose is no longer maintained, see https://github.com/nose-devs/nose/issues/1099#issuecomment-562394879.

This bug was initially submitted here: https://bugs.gentoo.org/878695.

This commit switches to pytest.

Amongst the changes, here are the most relevant ones:

Create a conftest.py that contains fixtures.
Replace nose.with_setup with yield fixtures.
Use pytest.skip instead of print and nose.plugins.skip.SkipTest.
Use pytest.mark.slow instead of nose.plugins.attrib.attr("slow").
Use pytest.mark.parametrize instead of parameterized, simplify parametrized tests that use both shell and inverse_order.
Update Travis config.
Update SConscript.
Update documentation.

sbraz commented 1 year ago

@Cebtenzzre would it please be possible to look into this?

cebtenzzre commented 1 year ago

I know that nose is unmaintained, but it works fine on the distro I use (Arch Linux). I would like to replace it with something like nose2 or pytest in the future, and I will consider your changes. But it is not a priority at the moment, and I've made a lot of changes to the tests locally that would conflict with this PR.

sbraz commented 11 months ago

@Cebtenzzre any chance you could look into this at one point? If I were to rebase this on master or develop (not sure I will because I already spent hours on this PR), would you merge it?

cebtenzzre commented 11 months ago

I haven't been spending much time on rmlint lately, but I would still want to push more of my own changes which include additional tests before I merge this PR.

sbraz commented 4 months ago

Hi @cebtenzzre, FYI Gentoo is about to drop the package because it's one of the few that haven't migrated away from nose, see https://bugs.gentoo.org/878695#c5.

It saddens me as I put a lot of hours into packaging it, making the test suite work, and creating this PR. I really liked using rmlint too. I still think pytest is the way to go and nose2 is not the best solution. If you think you can fix this in the coming weeks, that would be really nice and maybe I can add it back at some point.