search

sahib / rmlint

Extremely fast tool to remove duplicates and other lint from your filesystem
http://rmlint.rtfd.org
GNU General Public License v3.0
1.86k stars 128 forks source link

[Feature] Warn / exit when tagging but no using it #606

Open jrz opened 1 year ago

jrz commented 1 year ago

I accidently started rmlint without --keep-all-tagged / --keep-all-untagged.

I'm not sure what uses tagging has besides these, but it makes sense to just exit if no usage is specified when tagging.

jrz commented 1 year ago

Never mind.. tagging has uses too.

cebtenzzre commented 1 year ago

Tagging is primarily used to indicate preferred files and directories. The only usage that might not make sense is rmlint // files... (no untagged paths), but I don't see the harm in continuing to allow it.

jrz commented 1 year ago

I don't know, I've used rmlint a number times, but I simply forgot to add the option flags.

Maybe adding an option such as '--prefer-tagged' makes sense to make things a bit more explicit.

cebtenzzre commented 1 year ago

Well, I guess I might consider changing the interface. Because the default -S pOma means that the first named paths are preferred by default anyway, so simply tagging paths without -k/K/m/M is in fact not necessary. Tagging is a more explicit way to prefer them but I suppose if you are going to be explicit you probably want something specific.