Only original_cmd in shell script generated for reflink

sahib / rmlint

Extremely fast tool to remove duplicates and other lint from your filesystem

http://rmlint.rtfd.org

GNU General Public License v3.0

1.85k stars 128 forks source link

Only original_cmd in shell script generated for reflink #642

Open EchterAgo opened 7 months ago

EchterAgo commented 7 months ago

I'm trying rmlint 2.9 and latest git master (d9c80478a4bb1cd3ecfeecd1021ee28995c07134) on a ZFS filesystem with reflink support and am seeing the same issue as reported by others in the new closed #407 issue.

The binary is linked with blkid but the output still only contains original_cmd.

It works fine when using sh:handler=hardlink and when I edit the generated file using perl -pe 's/cp_hardlink(?!\()/cp_reflink/g' rmlint.sh > rmlint_new.sh it reflinks successfully.

EchterAgo commented 7 months ago

Note that with ZFS currently a cp --reflink=always does not work across datasets. cp --reflink=auto should work but for me I have to use cp --sparse=never --reflink=auto.