sahil-kale / basilisk-actuator-control-lib

Hardware-agnostic library enabling field oriented control of of PMSM and BLDC Motors
https://sahil-kale.github.io/basilisk-actuator-control-lib/
1 stars 0 forks source link

Remove bridge reference from sensorless Rotor Sector Sensor #42

Closed sahil-kale closed 10 months ago

sahil-kale commented 10 months ago

The sensorless rotor sector sensor is still taking in a bridge object... this should be smited and instead, use the params available and have the control loop pass these values in.

sahil-kale commented 10 months ago

Going to remove this for now - the reason this is maintained is because we draw a pretty clear line that the sector sensor points 'down' to the HW, and should not rely on data from upwards. In this sense, relying on a bridge is ok.