sahil-kale / basilisk-actuator-control-lib

Hardware-agnostic library enabling field oriented control of of PMSM and BLDC Motors
https://sahil-kale.github.io/basilisk-actuator-control-lib/
1 stars 0 forks source link

[BLDC] Only enable rotor offset compensation when hall interpolation … #45

Closed sahil-kale closed 8 months ago

sahil-kale commented 8 months ago

…is enabled

The commit enabling sector offset compensation accidentally made some poor unit tests wherein the raw hall angle was not passed through if interpolation was disabled.

This feature should only be active if interpolation is also active, otherwise it does not make sense to actually enable this feature.

Fix adds a param flag for this and also fixes the unit tests to ensure raw hall angle passthrough

https://github.com/sahil-kale/basilisk-actuator-control-lib/issues/41