search

sahilchaddha / homebridge-magichome-platform

Homebridge Plugin for MagicHome LED Strips with Preset Scene Automation Support (Cycle Color/Fade/Strobe)
MIT License
47 stars 12 forks source link

Brightness + Siri bug #12

Open ageorgios opened 5 years ago

ageorgios commented 5 years ago

Describe the bug Status: Turned off I say to SIRI: Turn Strip1 red

Expected behavior Turned on Brightness: 100% Color: RED

Actual behavior Turned on Brightness: 0% Color: RED

so no red light.

sahilchaddha commented 5 years ago

Hey @ageorgios , This looks like HomeKit issue. I can reproduce the issue. Homekit only sends On Command & color command. It doesnt send command to update the brightness. We can add a workaround on the plugin side. Whenever lights are being turned off, plugin also sets brightness of the lights. Will this approach solve your issue ?

ageorgios commented 5 years ago

I think the best approach is when homebridge-magichome-platform turns on the accessory, should check for brightness and in case it is 0% set it to 100%.

This way it will remember if someone set the brightness to a lower than 100 value before, although it will turn on the light in case the brightness is set to 0% from a previous turn off command.