Missing Return keyword in Google_CurlIO::getCachedRequest()

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Google_CurlIO::makeRequest() on the first line calls 
$this->getCachedRequest($request);
2. For authorized requests which shouldn't be cached 
Google_CurlIO::getCachedRequest() fails to return early causing undefined 
behavior.

What is the expected output? What do you see instead?
The initial cachability test should "return FALSE" but what is actually 
happening is just "false;" and the function continues without returning.

What version of the product are you using? On what operating system?
Trunk, CentOS 5.5 x64 LAMP

Please provide any additional information below.
I tried to create a Unit Test but the condition is just too obscure to warrant 
the complex testing required. Simply adding the return keyword.

Original issue reported on code.google.com by benb...@gmail.com on 5 Mar 2013 at 11:39

Attachments:

• missing-return-CurlIO.patch

[GoogleCodeExporter]

Yep, that's definitely a mistake! Just needs the return added as you say.

Original comment by ianbar...@google.com on 22 Mar 2013 at 6:18

• Changed state: Accepted

[GoogleCodeExporter]

This issue tracker is now closing. Development on the Google PHP client library 
moved to GitHub with the release of the 1.0.0-alpha, and now the 1.0 branch has 
reached beta status there will be no further releases of the 0.6 branch of the 
library. 

Please take a look at the latest version on 
https://github.com/google/google-api-php-client

For information on migrating, please take a look at this guide: 
https://developers.google.com/api-client-library/php/guide/migration

For general library support please ask a question on StackOverflow: 
http://stackoverflow.com/questions/tagged/google-api-php-client

If you are looking for support with a specific API, please contact the team 
working with that API via StackOverflow or their preferred support mechanism. 

If your issue still exists with the new version of the library, please raise a 
bug in the GitHub issue tracker with a minimal code sample. 

Thanks!

Original comment by ianbar...@google.com on 22 Jan 2014 at 4:53

• Changed state: Done