search

sahin / VideoSplashKit

VideoSplashKit - UIViewController library for creating easy intro pages with background videos
MIT License
1.22k stars 137 forks source link

Added swift 3 support #35

Closed mruvim closed 6 years ago

mruvim commented 7 years ago

Converted to swift 3. Changed output path of output.mp4 to /tmp instead of /Documents, for reasons please check iOS Data Storage Guidelines

hoangtam101 commented 7 years ago

Hey mruvim: why change path of uotput.mp4 to /tmp instead of /Documents I see the rule Data that is used only temporarily should be stored in the /tmp directory. Although these files are not backed up to iCloud, remember to delete those files when you are done with them so that they do not continue to consume space on the user’s device. I think this path exactly for this rule ?

mruvim commented 7 years ago

@hoangtam101 Documents directory is automatically backed up to iCloud on devices which have iCloud enabled. Output video can always be regenerated from original file therefore there is no need to store it in docs directory. Storing in /tmp directory will allow system to clean up files in case system needs more memory. We need to make sure we're using users memory responsibly.

hoangtam101 commented 7 years ago

@mruvim Thank you. i got it.

hoangtam101 commented 7 years ago

@mruvim Hi Mruvim: I just compare my code and your code was submitted. But this code not work on iPhone 7. Are you check it on iPhone 7 with XCode 8 ? Thank you.

mruvim commented 7 years ago

@hoangtam101 you are right, for some reason when compiled in Xcode 8 on iOS 10 sim video doesn't work, but it does work on actual device. When i'll have time i'll investigate what's going on with iOS 10 sim

hoangtam101 commented 7 years ago

@mruvim Thank you for your reply. I'm just run on device ios 10. this code work well on device. Thank you