Bib+Why 60->14+packageCapitalization+cs3

sahirbhatnagar / cbpaper

Source code for Casebase paper

Other

2 stars 1 forks source link

Bib+Why 60->14+packageCapitalization+cs3 #13

Closed Jesse-Islam closed 4 years ago

Jesse-Islam commented 4 years ago

Fixed Bib, added a short description of why we went from 60-14, fixed package capitalization (though this was done using find and replace, so I will read everything over to insure no errors were introduced. the case studies all compile, however.) I also updated case study 3 to use the support data included in casebase. TODO:

CS3: describe chosen individual for absolute risk function
lit review table header is not centered.
typos and general writing flow.
There appears to be a unicode character introduced in the .RMD. I was not able to find it, so I set it to be ignored in the preamble. Finding and updating this character may be worth it, if the character is indeed important.

turgeonmaxime commented 4 years ago

@Jesse-Islam I don't think you read my comments on the other pull-request carefully. I asked you to make the changes on a very specific branch, because I had already edited your literature review. Since you made the changes on the master branch instead, I won't be able to merge your changes.

So here's what we'll do: I'll incorporate as many change as I can (e.g. those to references.bib should be easy to incorporate), but you will probably have to go through again and fix the capitalization issues. I'll let you know once you can do this, and on which branch to do it

Jesse-Islam commented 4 years ago

Ah I misunderstood which branch I was on. Sorry about that! I'm a tad new to git collaborations.

Not to worry! Ill remove this commit and make the changes on the correct branch.

turgeonmaxime commented 4 years ago

I've merged these changes (the ones I could) into the review branch, so I'm closing this pull-request