sahlberg / fuse-nfs

A FUSE module for NFSv3/4
GNU General Public License v3.0
172 stars 41 forks source link

Readme Markdown Document has error in option part #46

Closed tyrxuann closed 1 year ago

tyrxuann commented 1 year ago

I found that the README document states that the "umask" option is specified with "-U", but the source code handles the "umask" option with "-K"

READNE.md

[-U UMASK|--umask=UMASK]
        Override the permission bits in st_mode set by the filesystem. 
        The resulting permission bits are the ones missing from the given umask value.  
        The value is given in octal representation.

fuse-nfs.c

case 'K':
            snprintf(fuse_Umask_arg, sizeof(fuse_Umask_arg), "-oumask=%s", optarg);
            fuse_nfs_argv[fuse_nfs_argc++] = fuse_Umask_arg;
            break;

Print help also has same error

sahlberg commented 1 year ago

Can you send a pull request to fix this?

tyrxuann commented 1 year ago

Can you send a pull request to fix this?

I can do it.

tyrxuann commented 1 year ago

Can you send a pull request to fix this?

I had send a pr to fix this with #47.

tyrxuann commented 1 year ago

solve it with #47.