search

sahlberg / libnfs

NFS client library
Other
524 stars 201 forks source link

Fix deprecation warnings on modern macOS #403

Closed pborzenkov closed 1 year ago

pborzenkov commented 1 year ago

syscall() and POSIX semaphores are deprecated on modern macOS. Thus, libnfs can't be compiled with -Werror and multi-threading there.

To fix this, replace POSIX semaphores with the ones from libdispatch (available since 10.6 as part of the standard SDK) and syscall(gettid) with non-portable pthread function.

Both changes are behind autoconf check, so hopefully won't break anything.

pborzenkov commented 1 year ago

Hmm, both Cygwin and OpenBSD failures seem to be unrelated to the changes made by this PR.

sahlberg commented 1 year ago

Merged, thanks