sahlberg / libsmb2

SMB2/3 userspace client
Other
310 stars 126 forks source link

Add Arlen lt patches #321

Open Wolf3s opened 5 months ago

Wolf3s commented 5 months ago

See the commits for more informations.

Wolf3s commented 5 months ago

@sahlberg the PR is ready to go.

Wolf3s commented 5 months ago

Note: there's function which is:

void SMB2APIENTRY smb2_set_version(struct smb2_context *smb2,
                      enum smb2_negotiate_version version)
{
    smb2->version = version;
}

and @Arlen-LT has added:

void SMB2APIENTRY smb2_set_negotiate_version(struct smb2_context* smb2, enum smb2_negotiate_version version)
{
    smb2->version = version;
}

enum smb2_negotiate_version SMB2APIENTRY smb2_get_negotiate_version(struct smb2_context* smb2)
{
    return smb2->version;
}

enum smb2_negotiate_version SMB2APIENTRY smb2_get_dialect_version(struct smb2_context* smb2)
{
    return smb2->dialect;
}

Which is the same of the other one but with plus, However i kept the other one for backwards compatibility maybe in the next-gen smb2 this smb2_set_version should be removed.

sahlberg commented 3 months ago

Can you update this and resolve the conflicts?

Wolf3s commented 3 months ago

Can you update this and resolve the conflicts?

Yes.

Wolf3s commented 3 months ago

@sahlberg i solved the conflict you can merge now.