Cmake and windows socket check fixes.

sahlberg / libsmb2

SMB2/3 userspace client

Other

322 stars 137 forks source link

Cmake and windows socket check fixes. #327

Closed memecode closed 6 months ago

memecode commented 6 months ago

These fixes are related to fixing the cmake target includes for the smb2 target. And the socket validity checks on windows, where the SOCKET (t_socket) type is unsigned.

sahlberg commented 6 months ago

Merged but the windows build is broken. I fixed the non-windows builds by moving the defines so they would apply also for non xbox/windows/mingw builds so all other platforms should work now. But windows still fails.

Can you have a look?

memecode commented 6 months ago

@sahlberg I've committed a windows build fix on the source branch: 00fd58666f7005d40cafc80f55e1b660069bca21

sahlberg commented 6 months ago

Awesome. Thanks! Send a pull request and I will merge it.