search

sahlberg / pop-fe

Python script to automate the process of fetching boxart and installing PS1 games (onto your PSP/VITA/PS2/PS3)
171 stars 15 forks source link

Support for Tales of Destiny 1 & 2 with Spanish patch #171

Closed AdrCant closed 6 months ago

AdrCant commented 6 months ago

I've been using the program, and it's been working very well. However, when I try to convert Tales of Destiny with the applied Spanish translation patch, the program doesn't recognize it and gives an error. It also mentions that there's an issue because track 2 is labeled as PREGAP. I've attempted to resolve it by manually editing the CUE file, but it results in another error. Is it possible to address these issues? I'm providing a link to download the patched game: https://archive.org/details/psx-compilacion-de-traducciones-en-espanol_202305 There are two versions available, one with the Japanese opening and one without. I've tried both versions, and they both encounter the same error. It seems that Tales of Destiny II might have the same problem, although I haven't tested it yet.

Nanando0 commented 6 months ago

pop fe generates an MD5 from each disk.

It will be necessary to correctly post each MD5 generated in the pop fe log related to each game and its disc.

sahlberg commented 6 months ago

As @Nanando0 said. Post the md5 that pop-fe prints and the corresponding disc id for the patched disks and I can add them to the database.

AdrCant commented 6 months ago

I've already tested the patched Tales of Destiny 2, and the program recognized it without any issues. Both versions were recognized, but it presents the same PREGAP warning as Tales of Destiny 1. When converting each track, the following message appears in the log:

Cue2cu2: Warning while processing /user/downloads/game.cue: The PREGAP command is used for track 2, which requires the software to insert data into the image or disc. This is not supported by Cue2cu2. The pregap will be ignored, and a zero-length pregap will be noted in the CU2 sheet to continue. However, the resulting bin/CU2 set might not work as expected or not at all. If possible, please try a Redump compatible version of this image.

AdrCant commented 6 months ago

The MD5 checksums for the two versions of Tales of Destiny are as follows:

With Japanese Opening: 6a9cf2aa79bb282048ee0f121c76d488

Without Japanese Opening: e02babf39484755432d988a3d545d312

The ID for the patched versions is as follows (obtained through psx2psp): SLES10626.

It is worth mentioning that the patch is applied to the NTSC-US version of the game.

sahlberg commented 6 months ago

SLES10626 must be wrong. SLES is the code for PAL games and not NTSC-U. (However, the NTSC-U version of Tales Of Destiny is SLUS00626)

Instead, just tell me which game these refers to and I can link them to the right disc: With Japanese Opening: 6a9cf2aa79bb282048ee0f121c76d488 Without Japanese Opening: e02babf39484755432d988a3d545d312

Are these Tales Of Destiny 1 or 2 is is one of them for TOD1 and the other for TOD2 ?

AdrCant commented 6 months ago

SLES10626 must be wrong. SLES is the code for PAL games and not NTSC-U. (However, the NTSC-U version of Tales Of Destiny is SLUS00626)

Instead, just tell me which game these refers to and I can link them to the right disc: With Japanese Opening: 6a9cf2aa79bb282048ee0f121c76d488 Without Japanese Opening: e02babf39484755432d988a3d545d312

Are these Tales Of Destiny 1 or 2 is is one of them for TOD1 and the other for TOD2 ?

Both MD5 are from Tales of Destiny 1, it's just that the Spanish translation patch allows you to replace the American opening with the Japanese one or keep the American opening.

AdrCant commented 6 months ago

I've already tested the patched Tales of Destiny 2, and the program recognized it without any issues. Both versions were recognized, but it presents the same PREGAP warning as Tales of Destiny 1. When converting each track, the following message appears in the log:

Cue2cu2: Warning while processing /user/downloads/game.cue: The PREGAP command is used for track 2, which requires the software to insert data into the image or disc. This is not supported by Cue2cu2. The pregap will be ignored, and a zero-length pregap will be noted in the CU2 sheet to continue. However, the resulting bin/CU2 set might not work as expected or not at all. If possible, please try a Redump compatible version of this image.

As I said, Tales of Destiny 2 is recognized by the program but has this warning message when converting track 2 of each disc to AT3. The same thing happens with Tales of Destiny 1. The issue arises because Track 2 is labeled as both PREGAP and AUDIO in the CUE file. I've verified that unpatched discs only have AUDIO labels, indicating that PREGAP is a result of the patch. I've attempted manual modifications to the CUE file, resulting in errors during AT3 conversion. Does this cause any problems, and if so, can it be resolved? I've conducted tests on both the Windows and Linux versions of the program.

sahlberg commented 6 months ago

I added these md5 so they should be detected as Tales Of Destiny now.

The complaint about pregap I can not do anything about. This error means that the bin/cue files are bad. Possibly the patch is broken or did not know how to update the cue file correctly? Don't know. Maybe tell the patch author that it generates a bad cue file.

As for what the effect will be? Hard to say, it could play the CDDA tracks just fine, or there could be issues with the audio. I think most likely it will work but possibly the audio might be shifted so that it is not synced correctly with the game. If if it just background music it probably does not matter and is probably not even noticeable if this happens. If the CDDA tracks are voice audio for cut-scenes then it might be very off-putting and ruin the experience.

If the game converts and the background audio seems fine then you can just ignore this warning that the cue file is bad.