[Suggestion] Handle passing in a pre-made AT3

[ParzivalWolfram]

The current code does not handle pulling in a pre-converted AT3 file, and will try to re-encode it. As these were required for custom sounds in the past, it would be beneficial to check if a re-encode is necessary in the first place for those trying to use pre-made files.

[sahlberg]

Can you give the latest master a try? I have added some basic conditionals to just use the snd0 file as-is without any conversion if it looks like it is in at3 format but have not had much time to test properly.

[ParzivalWolfram]

This didn't work, my AT3s are still re-encoded again. I don't see any output to give to clarify the issue, unfortunately.

[sahlberg]

When you say AT3, do you mean the SND0 that is played on the XMB when the game is selected? Or do you mean the in-game CD-DA audio tracks?

[ParzivalWolfram]

The passed-in SND0 file, apologies.

On Mon, Aug 21, 2023 at 6:35 AM Ronnie Sahlberg @.***> wrote:

When you say AT3, do you mean the SND0 that is played on the XMB when the game is selected? Or do you mean the in-game CD-DA audio tracks?

— Reply to this email directly, view it on GitHub https://github.com/sahlberg/pop-fe/issues/36#issuecomment-1686161551, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE6CQI64EGT5J3ZRAHB2FTXWNBXLANCNFSM6AAAAAA3N4L6GQ . You are receiving this because you authored the thread.Message ID: @.***>

[sahlberg]

It might be the detection of "is this already AT3" that is failing. I made the detection based on how the files created by atracdenc and similar works. Can you send me a short file that you use and I can look at how to detect it as already processed correctly.

[ParzivalWolfram]

out.at3.tar.gz Produced using https://www.modconsoles.fr/club-articles.html/pc/at9at3-converter-v23-r36 forever ago, though I think it was an older revision.

[sahlberg]

And that file, you just add it as SND0.AT3 to the games directory and it will play? I will have a look at this on saturday or sunday.

[ParzivalWolfram]

I think PSX2PSP bakes it into the EBOOT, but it plays just fine on the XMB menu in either case. Sometimes it won't load if it's next to the EBOOT, but it always works when baked into the EBOOT, even if the EBOOT itself doesn't load.

[sahlberg]

Can you try current master? I loosened up the check for compression_code to allow your file to be accepted as valid. Looking at the code value I am not sure that your file is even at3 but whatever, it should allow your file now as is

On Wed, 23 Aug 2023 at 11:23, Parzival Wolfram @.***> wrote:

I think PSX2PSP bakes it into the EBOOT, but it plays just fine on the XMB menu in either case, yes.

— Reply to this email directly, view it on GitHub https://github.com/sahlberg/pop-fe/issues/36#issuecomment-1689125111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADY3EHRKRNX6OGLY5SLQUDXWVLQ5ANCNFSM6AAAAAA3N4L6GQ . You are receiving this because you commented.Message ID: @.***>

[sahlberg]

resolved