sahlberg / pop-fe

Python script to automate the process of fetching boxart and installing PS1 games (onto your PSP/VITA/PS2/PS3)
161 stars 15 forks source link

Dragon Warrior can't be converted. #52

Closed Webardo closed 11 months ago

Webardo commented 11 months ago

Hello, it's me again. How you doing?

Sorry to bother. Going straight to the point, this game (both discs SLUS-01206 and SLUS-01346) shows the following issue: cdrom: line in system.cnf does not contain a proper id, read disc label instead ID DRAGONWAR Exception in Tkinter callback Traceback (most recent call last): File "tkinter__init.py", line 1892, in call__ File "pop-fe-psp.py", line 349, in on_path_changed File "pop-fe-psp.py", line 181, in update_assets File "pop-fe.py", line 180, in get_game_from_gamelist KeyError: 'DRAGONWAR'

The issue comes from the game itself though. Disc 1 has this in the cnf file "SLUSP012.06;1" instead of "SLUS_012.06;1". Same thing applies to disc 2, with it having "SLUSP013.46;1" instead of the proper "SLUS_013.46;1".

Is it too much trouble to fix?

sahlberg commented 11 months ago

Not too much trouble at all. Pop-fe needs to be perfect so eveything like this needs to be fixed.

I already have a database for "broken" disc-ids so I just had to add these two disks to it and now they are re-mapped correctly to the right id. Sould be able to test once the next build completes.

Thanks!

Webardo commented 11 months ago

I should be thanking you, the least I can do is notify of issues.

Will test in a few moments and comment how it goes :).

Webardo commented 11 months ago

Works great, thank you!