search

sahlberg / pop-fe

Python script to automate the process of fetching boxart and installing PS1 games (onto your PSP/VITA/PS2/PS3)
135 stars 13 forks source link

Update Dockerfile (from Debian 10 to Debian 11) #54

Closed Fabax01 closed 8 months ago

Fabax01 commented 8 months ago

Fixes cmake atracdenc (install TARGETS given no RUNTIME DESTINATION)

sahlberg commented 8 months ago

Merged, thanks!

Fabax01 commented 8 months ago

Hello,

I forgot to set the python version in the docker file, it seems that from 3.12 onward wrong escape sequences are marked as syntax warnings and not deprecation warnings. A end user might think they are errors. Even if this weren't the case, letting python update with every major release may break compatibility. 3.11 is the last one which does not nag a user - and it does work... But I see that buildbot for linux is configured with 3.10 - should I update the docker file with 3.10 instead?

sahlberg commented 8 months ago

Either or. Either try updating the build to 3.12 or change the docker to 3.10. Updating to 3.12 is probably best. Just test that it works.

Fabax01 commented 8 months ago

With 3.12 it does run, does not error out, it is only a warning after all. I also tested with Debian 12 instead of 11, so we can bring everything to current release.