search

sahlberg / pop-fe

Python script to automate the process of fetching boxart and installing PS1 games (onto your PSP/VITA/PS2/PS3)
135 stars 13 forks source link

Wrong Resolution of PIC1.PNG for PS3 PKGs and other Fixes #8

Closed HiroTex closed 2 years ago

HiroTex commented 2 years ago

When the script does the following instructions: image = image.resize((480, 272), Image.BILINEAR).convert("RGBA") image = add_image_text(image, game_title, game_id)

It wrongly resizes the image selected for PIC1 to a lower resolution image, then it scales that lower resolution image to 1920x1080 when doing the PS3 Package, making a very low resolution image for PS3 Backgrounds, it also includes unnecessary debug info (?) to it.

If this resize is meant to be done for PSP/Other consoles, I recommend to do that resize on those functions, and leave the 1980x1080 or another resolution as the base one when loading the image, also for a better presentation I suggest to comment out the add_image_text line of code there.

I also made some changes to the code to include support for a custom Info PIC0.PNG for the "create_ps3" function, I suggest that you add them properly with the proper code changes (My solution is just temporary for this case) and delete it or do not create it when creating the PS3 PKG if it is not found, because the presentation on the XMB will look bad with a duplicated PIC1 image in the front, that also hides the Title (Name of the Game). I will attach my modified pop-fe.py to this message if you want to look at it.

Thank you very much for reading, your program is really awesome and makes PSX Games on the PS3 very easy to make and to see in our collections, so these are just really nitpicks, but it would be great if you could fix them! pop-fe.zip

HiroTex commented 2 years ago

Another Bug (And Fix): When creating a PS3 PKG from a multiple bin game the program will make a new merged Bin Cue on another directory (the program's base directory), so when it is scanning for custom ICON0 and PIC1 (and in my custom version, PIC0) images, it will try to search for those images on the merged bin/cue directory instead of the selected bin/cue directory specified.

To Fix this, the line: image = Image.open(create_path(img_files[0], 'X.PNG'))

must be changed to use args.files[0] instead: image = Image.open(create_path(args.files[0], 'X.PNG'))

pop-fe.zip

sahlberg commented 2 years ago

Thankyou for using pop-fe! I have done these changes you suggested but in a slightly different way. Please have a look at current master and let me know if there is anything more I need to fix to make it better.

Thanks!

HiroTex commented 2 years ago

Everything looks great, thank you! I'll keep using it for my other PSX Games and report anything I can find.