sahwar / 7plus

Automatically exported from code.google.com/p/7plus
1 stars 0 forks source link

Some code revision... #324

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I'm currently reading a very good book on software construction - "Code 
Complete" - and I already picked up some tips. I will be posting things here 
where code might be improved so I can do it when I find time and/or motivation 
for it.

1) Loosen coupling in event system:
- Settings.ahk makes mentions of specific event types to decide whether to show 
some events. This should better be a generic property of an event.
- A generic event test file should be generated that shows all possible event 
methods and properties in one place.
- Eventually all subevents could be converted to classes. This would be very 
good but it's a huge amount of work.
- Initialization of subevent properties could be wrapped into a method for 
better coherence and default handling.

2) Rework program settings:
- First of all, introduce a class that handles and stores the settings which 
are currently located in settings.ini. Having them stored as global variables 
is just plain bad and a leftover from my starting AHK days where 7plus was just 
a very tiny program.
- Make the settings window use my CGUI library. The settings window is a 
central part of this program and should be updated sometime.

3) Organize MiscFunctions.ahk. It's growing way too large and needs to be 
splitted up, possibly in (static) classes.

4) Clean up array functions. The current library is still from very early AHK_L 
revisions when objects where introduced and newer features are available now. 
Make sure to maintain compatibility.

5) Maybe setup string methods in the base string object.

6) Add Asserts whereever possible/necessary once a proper error handling 
mechanism is available. This should be possible in the next AHK_L version.

Original issue reported on code.google.com by fragman@gmail.com on 7 Sep 2011 at 8:49

GoogleCodeExporter commented 8 years ago
- Initialization of subevent properties could be wrapped into a method for 
better coherence and default handling.
-> Implemented.

Original comment by fragman@gmail.com on 11 Sep 2011 at 8:38

GoogleCodeExporter commented 8 years ago
2) Done.

Original comment by fragman@gmail.com on 15 Oct 2011 at 10:17

GoogleCodeExporter commented 8 years ago
1) mostly done except for first point, testing and (quite some) bug fixing.
4) done.

Original comment by fragman@gmail.com on 26 Oct 2011 at 10:04

GoogleCodeExporter commented 8 years ago

Original comment by fragman@gmail.com on 17 Nov 2011 at 9:16

GoogleCodeExporter commented 8 years ago

Original comment by fragman@gmail.com on 14 Feb 2012 at 10:53

GoogleCodeExporter commented 8 years ago

Original comment by fragman@gmail.com on 25 Feb 2012 at 2:42

GoogleCodeExporter commented 8 years ago
I'll close this for now, as the most important things have been implemented.

Original comment by fragman@gmail.com on 10 May 2012 at 11:50