search

sai3010 / Typesense-Kubernetes-Operator

An operator to manage Typesense clusters on Kubernetes
Apache License 2.0
34 stars 11 forks source link

add ingress, add costum clusterdomain #7

Open tobstone opened 7 months ago

tobstone commented 7 months ago

Hi Sai, i am using your operator, but i missed an ingress and the possibility to edit the clusterdomain. maybe you like to integrate it back.

sai3010 commented 7 months ago

Hi @tobstone , I did not want to create a default ingress because, its something that you can create whenever you want to expose it outside the cluster either public or private. The ingress could be of multiple types aws , azure etc. Any particular reason that you wanted this ingress to be managed by operator?

tobstone commented 7 months ago

ah i see, so many diffrent approaches, for me its much easier to define the ingress with the operator, i am also using it only on vanilla k8s, so only one flavor, maybe make it optional?

sai3010 commented 7 months ago

Yes, I understand but ideally, an operator should not manage ingress is what I belive to be a good practice. I will definitely see a better way to solve this for you. :)