Completion adds extra zero to the end of the line

[joncarr]

When I complete a candidate the completion adds a literal 0 to the end of the line. This behavior started after switching from go-langserver to bingo.

As an example, if I type fmt.Prin and complete Println the resulting completion is

fmt.Println(a)0

OS: ArcoLinux Editor: Emacs 26.1 Completion Backend: Company

[Jackson-soft]

same issue

[saibing]

@joncarr @Jackson-soft

I can't reproduce the problem in both vscode and coc.nvim, I won't use emacs, is it an issue handled by emacs lsp client?

[s-kostyaev]

It's issue on eglot & yasnippet side

[s-kostyaev]

But if change last tabstop from ${0} to $0 it will be fixed

[joncarr]

I don't use eglot, and I've used yasnippet for a long time without the extra zero being an issue. So I'm unsure how it's an issue with any of those.

@saibing I don't think it could be an issue with the LSP client either. I've used lsp-mode with go-langserver for a quite a while without any issue.

[s-kostyaev]

@joncarr before this https://github.com/saibing/bingo/pull/68

[s-kostyaev]

@saibing looking into https://microsoft.github.io/language-server-protocol/specification#textDocument_completion we can do that:

But if change last tabstop from ${0} to $0 it will be fixed

I can create PR if you want.

[saibing]

@joncarr @s-kostyaev @Jackson-soft

I have changed last tabstop from ${0} to $0. Please try the latest version bingo

[joncarr]

I have pulled the latest changes from master branch and installed the latest client.

git pull
GO111MODULE=on go install

And now the server will not start for me. Just spins on starting

[saibing]

@joncarr

please set flag: --trace, --logfile=/tmp/bingo.log, and then check /tmp/bingo.log.

[s-kostyaev]

@saibing fixed, thanks